Codecov Report

Merging #210 (7b7cbad) into main (94dd041) will increase coverage by 0.36%.
Report is 2 commits behind head on main.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   51.53%   51.90%   +0.36%     
==========================================
  Files          51       51              
  Lines        3415     3447      +32     
==========================================
+ Hits         1760     1789      +29     
- Misses       1364     1366       +2     
- Partials      291      292       +1     

@xiaoyu74: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard.

I think we should better not print the job id if it is a dry run?

$ ocm backplane2 testjob create -d
...
...

TestId: openshift-job-1695719774

I think we should better not print the job id if it is a dry run?

$ ocm backplane2 testjob create -d
...
...

TestId: openshift-job-1695719774

if err != nil {
    utils.WriteJson(w, http.StatusInternalServerError, &utils.ErrorResponse{
        StatusCode: http.StatusInternalServerError,
        Message: fmt.Sprintf("Failed running dryrun for job on the cluster, error: %s", err),
    })
    return
}
utils.WriteJson(w, http.StatusOK, jobs.TestJobResult{
    TestId:  jobObjects.Pod.Name,
    Message: buf.String(),
    Status:  string(corev1.PodPending), // Always starts with Pending
})

@bmeng - Thanks for your review. I think it's just defined in the backplane API, if we think the TestId should not be printed, we can update in API code then but it's a separated issue from this PR.

I think we still can deal with it from https://github.com/openshift/backplane-cli/pull/210/files#diff-85bea5392ad379d93bf38a12b6a10a1b754877f9fd898d19ebaaf89c1a0f860fR184
But it is not a big deal, let's leave it as is.

/label tide/merge-method-squash
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here